Bug 151044 – Implement -[_WKRemoteObjectInterface debugDescription] and have it look like the NSXPCInterface equivalent

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Implement -[_WKRemoteObjectInterface debugDescription] and have it look like the NSXPCInterface equivalent

[Anders Carlsson]

Created attachment 265078 [details]
Patch

[WebKit Commit Bot]

Attachment 265078 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:186:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:190:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 265078 [details]
Patch

Should we really use NSMutableString instead of StringBuilder or something like that?

[Anders Carlsson]

(In reply to comment #3)
> Comment on attachment 265078 [details]
> Patch
> 
> Should we really use NSMutableString instead of StringBuilder or something
> like that?

Since this is debug-only code it doesn't really matter.

[Anders Carlsson]

Committed r192171: <http://trac.webkit.org/changeset/192171>

[Darin Adler]

Comment on attachment 265078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265078&action=review

> Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:197
> +                return CString(class_getName(a)) < CString(class_getName(b));

Why copy these strings with the CString constructor instead of just using strcmp directly?

[Darin Adler]

Comment on attachment 265078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265078&action=review

>> Source/WebKit2/Shared/API/Cocoa/_WKRemoteObjectInterface.mm:197
>> +                return CString(class_getName(a)) < CString(class_getName(b));
> 
> Why copy these strings with the CString constructor instead of just using strcmp directly?

I guess the answer is “debug-only code and doesn’t matter”, but still!