Bug 151043 - B3->Air lowering should support CCall
Summary: B3->Air lowering should support CCall
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 151052 150279 151045
  Show dependency treegraph
 
Reported: 2015-11-09 12:00 PST by Filip Pizlo
Modified: 2015-11-09 16:27 PST (History)
11 users (show)

See Also:


Attachments
the patch (17.32 KB, patch)
2015-11-09 14:37 PST, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-09 12:00:06 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2015-11-09 14:37:12 PST
Created attachment 265098 [details]
the patch
Comment 2 WebKit Commit Bot 2015-11-09 14:40:39 PST
Attachment 265098 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/testb3.cpp:2674:  l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2015-11-09 15:07:03 PST
Comment on attachment 265098 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265098&action=review

r=me

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:1164
> +        // Compute the place that this goes onto the stack. On X86_64 and probably other calling

ARMv7 and ARM64 too?
Comment 4 Filip Pizlo 2015-11-09 15:51:18 PST
(In reply to comment #3)
> Comment on attachment 265098 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265098&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/b3/B3LowerToAir.cpp:1164
> > +        // Compute the place that this goes onto the stack. On X86_64 and probably other calling
> 
> ARMv7 and ARM64 too?

Probably, but I haven't checked yet. :-)
Comment 5 Filip Pizlo 2015-11-09 16:27:52 PST
Landed in http://trac.webkit.org/changeset/192187