Bug 151033 - [Streams API] Shield promises when prototype is replaced from a promise
Summary: [Streams API] Shield promises when prototype is replaced from a promise
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 09:24 PST by Xabier Rodríguez Calvar
Modified: 2015-11-10 05:25 PST (History)
4 users (show)

See Also:

Attachments
Patch (10.04 KB, patch)
2015-11-09 09:27 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (9.96 KB, patch)
2015-11-09 11:18 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2015-11-09 09:24:26 PST 
[Streams API] Shield promises when prototype is replaced from a promise
Comment 1 Xabier Rodríguez Calvar 2015-11-09 09:27:30 PST 
Created attachment 265062 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2015-11-09 09:51:29 PST 
I'll land this tomorrow as I don't have too much time left.
Comment 3 Xabier Rodríguez Calvar 2015-11-09 11:18:34 PST 
Created attachment 265076 [details]
Patch

Rebased, will cq+ tomorrow
Comment 4 WebKit Commit Bot 2015-11-10 00:51:02 PST 
Comment on attachment 265076 [details]
Patch

Clearing flags on attachment: 265076

Committed r192207: <http://trac.webkit.org/changeset/192207>
Comment 5 WebKit Commit Bot 2015-11-10 00:51:07 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 youenn fablet 2015-11-10 05:25:36 PST 
Nice work :)

The only minor issue I have is that the code is new somehow less readable.
It would have been good to be able to keep blabla.....@then.

One approach for doing so might be to do specific handling like for @call/@apply.
But I prefer your simpler approach. This is not worth it, at least in the current situation where streams API is the only API consuming user-land promises.