Bug 151021 - [Streams API] Activate assertions
Summary: [Streams API] Activate assertions
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Depends on:
Reported: 2015-11-09 07:22 PST by youenn fablet
Modified: 2015-11-09 10:06 PST (History)
4 users (show)

See Also:

Patch (9.35 KB, patch)
2015-11-09 08:26 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Rebasing (9.37 KB, patch)
2015-11-09 08:34 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-11-09 07:22:47 PST
As per the spec, we should enable some @assert in streams implementation.
Comment 1 youenn fablet 2015-11-09 08:26:53 PST
Created attachment 265053 [details]
Comment 2 youenn fablet 2015-11-09 08:34:47 PST
Created attachment 265054 [details]
Comment 3 youenn fablet 2015-11-09 08:36:05 PST
Patch activates assertion checking.
It fixes a small bug when pull promise is rejected.
This actually implements the "if" check of https://streams.spec.whatwg.org/#request-readable-stream-pull (step 7a)
Comment 4 WebKit Commit Bot 2015-11-09 10:06:49 PST
Comment on attachment 265054 [details]

Clearing flags on attachment: 265054

Committed r192160: <http://trac.webkit.org/changeset/192160>
Comment 5 WebKit Commit Bot 2015-11-09 10:06:54 PST
All reviewed patches have been landed.  Closing bug.