Bug 151018 - Built-in generator should check that there are no duplicate in JS built-in internal functions
Summary: Built-in generator should check that there are no duplicate in JS built-in in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-09 06:53 PST by youenn fablet
Modified: 2015-11-09 23:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (13.39 KB, patch)
2015-11-09 07:11 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2015-11-09 06:53:10 PST
Built-in generator should check that there are no duplicate in JS built-in internal functions.
Comment 1 youenn fablet 2015-11-09 07:11:09 PST
Created attachment 265045 [details]
Patch
Comment 2 WebKit Commit Bot 2015-11-09 07:12:49 PST
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment 3 WebKit Commit Bot 2015-11-09 07:12:59 PST
Attachment 265045 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/Scripts/builtins/builtins_generate_combined_header.py:152:  [BuiltinsCombinedHeaderGenerator.generate_section_for_code_name_macro] Instance of 'BuiltinsCombinedHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2015-11-09 07:13:38 PST
(In reply to comment #1)
> Created attachment 265045 [details]
> Patch

This patch only checks for duplicate for JSC.
Once bug 150482 is landed, WebCore should also be checked (although JSC+WebCore might not be checked).
Comment 5 BJ Burg 2015-11-09 09:39:50 PST
Comment on attachment 265045 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2015-11-09 23:21:22 PST
Comment on attachment 265045 [details]
Patch

Clearing flags on attachment: 265045

Committed r192202: <http://trac.webkit.org/changeset/192202>
Comment 7 WebKit Commit Bot 2015-11-09 23:21:25 PST
All reviewed patches have been landed.  Closing bug.