Bug 151013 – Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

On Windows 10 64-bit machine with Visual Studio 2015 Community Edition:

Followed instructions on http://trac.webkit.org/wiki/WindowsWithoutCygwin (except without iTunes or DirectX); except for building.

Then in a "normal" command prompt ("start->run cmd.exe")

cd PATH_TO_WEBKIT
perl Tools\Scripts\build-webkit --wincairo --release

Causes build failures in DumpRenderTree:
C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\PixelDumpSupport.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\win\PixelDumpSupportWin.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
c:\work\webkit\tools\dumprendertree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\work\WebKit\Tools\DumpRenderTree\win\ImageDiffCairo.cpp(32): fatal error C1083: Cannot open include file: 'cairo.h': No such file or directory [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\ImageDiffLib.vcxproj]

Looking into DumpRenderTreeLib.vcxproj it doesn't have the fully qualified path to the WebkitLibraries\win\include\cairo directory, it just has "\include\cairo".

Created attachment 265032 [details]
Patch

[Brent Fulgham]

I think this looks good, but let's let Alex Christensen double-check before we land.

[Alex Christensen]

Comment on attachment 265032 [details]
Patch

Yep.

[WebKit Commit Bot]

Comment on attachment 265032 [details]
Patch

Clearing flags on attachment: 265032

Committed r192167: <http://trac.webkit.org/changeset/192167>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.