Bug 151013 - Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
Summary: Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-08 20:43 PST by isaac+webkit
Modified: 2015-11-09 11:17 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2015-11-08 22:14 PST, isaac+webkit
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description isaac+webkit 2015-11-08 20:43:03 PST
On Windows 10 64-bit machine with Visual Studio 2015 Community Edition:

Followed instructions on http://trac.webkit.org/wiki/WindowsWithoutCygwin (except without iTunes or DirectX); except for building.

Then in a "normal" command prompt ("start->run cmd.exe")

cd PATH_TO_WEBKIT
perl Tools\Scripts\build-webkit --wincairo --release

Causes build failures in DumpRenderTree:
C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\PixelDumpSupport.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\win\PixelDumpSupportWin.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
c:\work\webkit\tools\dumprendertree\cairo\PixelDumpSupportCairo.h(38): fatal error C1083: Cannot open include file: 'cairo-win32.h': No such file or directory (compiling source file C:\work\WebKit\Tools\DumpRenderTree\cairo\PixelDumpSupportCairo.cpp) [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
C:\work\WebKit\Tools\DumpRenderTree\win\ImageDiffCairo.cpp(32): fatal error C1083: Cannot open include file: 'cairo.h': No such file or directory [C:\work\WebKit\WebKitBuild\Release\Tools\DumpRenderTree\ImageDiffLib.vcxproj]

Looking into DumpRenderTreeLib.vcxproj it doesn't have the fully qualified path to the WebkitLibraries\win\include\cairo directory, it just has "\include\cairo".
Comment 1 isaac+webkit 2015-11-08 22:14:20 PST
Created attachment 265032 [details]
Patch
Comment 2 Brent Fulgham 2015-11-09 09:50:21 PST
I think this looks good, but let's let Alex Christensen double-check before we land.
Comment 3 Alex Christensen 2015-11-09 10:27:29 PST
Comment on attachment 265032 [details]
Patch

Yep.
Comment 4 WebKit Commit Bot 2015-11-09 11:17:54 PST
Comment on attachment 265032 [details]
Patch

Clearing flags on attachment: 265032

Committed r192167: <http://trac.webkit.org/changeset/192167>
Comment 5 WebKit Commit Bot 2015-11-09 11:17:58 PST
All reviewed patches have been landed.  Closing bug.