Bug 151010 - MacroAssembler needs an API for disabling scratch registers
Summary: MacroAssembler needs an API for disabling scratch registers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 151669
Blocks: 151008
  Show dependency treegraph
 
Reported: 2015-11-08 18:22 PST by Filip Pizlo
Modified: 2016-02-16 18:26 PST (History)
12 users (show)

See Also:


Attachments
the patch (84.52 KB, patch)
2015-11-30 11:57 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (52.66 KB, patch)
2015-11-30 11:58 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-08 18:22:00 PST
When the scratch registers are disabled, any instruction that uses them should CRASH.  This should be used by Air::generate().
Comment 1 Filip Pizlo 2015-11-30 11:57:23 PST
Created attachment 266255 [details]
the patch
Comment 2 Filip Pizlo 2015-11-30 11:58:00 PST
Created attachment 266256 [details]
the patch
Comment 3 Michael Saboff 2015-11-30 12:03:54 PST
r=me as well.
Comment 4 Filip Pizlo 2015-11-30 12:07:43 PST
Landed in http://trac.webkit.org/changeset/192812
Comment 5 WebKit Commit Bot 2015-11-30 12:34:56 PST
Re-opened since this is blocked by bug 151669
Comment 6 Filip Pizlo 2016-02-16 18:26:14 PST
This definitely relanded, don't remember when, but it was a long time ago.