Bug 150994 - B3->Air lowering should do pattern matching the old fashioned way
Summary: B3->Air lowering should do pattern matching the old fashioned way
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2015-11-06 20:11 PST by Filip Pizlo
Modified: 2015-11-07 18:11 PST (History)
11 users (show)

See Also:

Attachments
work in progress (32.24 KB, patch)
2015-11-06 20:12 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (83.65 KB, patch)
2015-11-06 22:15 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-06 20:11:13 PST 
C++ and switch statements for the win.
Comment 1 Filip Pizlo 2015-11-06 20:12:27 PST 
Created attachment 264993 [details]
work in progress
Comment 2 Filip Pizlo 2015-11-06 22:15:18 PST 
Created attachment 264996 [details]
the patch
Comment 3 WebKit Commit Bot 2015-11-06 22:18:19 PST 
Attachment 264996 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3LowerToAir.cpp:448:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3LowerToAir.cpp:1155:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2015-11-07 13:01:02 PST 
Comment on attachment 264996 [details]
the patch

r=me
Comment 5 Filip Pizlo 2015-11-07 18:11:40 PST 
Landed in http://trac.webkit.org/changeset/192135