Bug 150985 - Modern IDB: Make the result data for a "get" request be an IDBGetResult
Summary: Modern IDB: Make the result data for a "get" request be an IDBGetResult
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-11-06 16:42 PST by Brady Eidson
Modified: 2015-11-06 17:13 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (28.72 KB, patch)
2015-11-06 16:45 PST, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-06 16:42:27 PST 
Modern IDB: Make the result data for a "get" request be an IDBGetResult

This is to better support the various types of object store and index gets in an upcoming patch
Comment 1 Brady Eidson 2015-11-06 16:45:21 PST 
Created attachment 264979 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-11-06 16:55:24 PST 
Attachment 264979 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/shared/IDBResultData.h:73:  The parameter name "getResult" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-11-06 17:13:41 PST 
https://trac.webkit.org/changeset/192123