Bug 150972 - Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
Summary: Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-06 04:49 PST by Csaba Osztrogonác
Modified: 2015-11-12 02:32 PST (History)
2 users (show)

See Also:


Attachments
Patch (46.68 KB, patch)
2015-11-06 04:54 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch (46.97 KB, patch)
2015-11-06 05:21 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-06 04:49:14 PST
ENABLE(SATURATED_LAYOUT_ARITHMETIC) was enabled for all ports 
by http://trac.webkit.org/changeset/172835 15 months before.

https://trac.webkit.org/changeset/172758 removed ENABLE(SUBPIXEL_LAYOUT) 
guards since it was already enabled by all ports.

Is there any reason to keep ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards?
If no, let's remove it. I'm going to prepare a patch and will propose
it on webkit-dev soon.
Comment 1 Csaba Osztrogonác 2015-11-06 04:54:49 PST
Created attachment 264934 [details]
Patch

WIP patch for EWS.
Comment 2 Csaba Osztrogonác 2015-11-06 05:21:39 PST
Created attachment 264936 [details]
Patch
Comment 3 Csaba Osztrogonác 2015-11-09 08:23:22 PST
Comment on attachment 264936 [details]
Patch

announcement on webkit-dev mailing list:
https://lists.webkit.org/pipermail/webkit-dev/2015-November/027781.html

Let's wait few days for possible discussion.
Comment 4 WebKit Commit Bot 2015-11-12 02:31:57 PST
Comment on attachment 264936 [details]
Patch

Clearing flags on attachment: 264936

Committed r192357: <http://trac.webkit.org/changeset/192357>
Comment 5 WebKit Commit Bot 2015-11-12 02:32:00 PST
All reviewed patches have been landed.  Closing bug.