Browser need to distinguish beforeunload and confirm to modify the message. For example, Firefox does not show the message of beforeunload event.
Created attachment 264904 [details] Patch
Comment on attachment 264904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264904&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:1060 > + return true; Why should we return true instead of false ?
Comment on attachment 264904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264904&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:1060 >> + return true; > > Why should we return true instead of false ? Beforeunload confirm pannel is for webpage(author) to ask that user really want to exit the current web page when requested navigation or close webview. So, IMO, it looks reasonable that default behavior is true, that leaves the current page or closes webview.
Comment on attachment 264904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264904&action=review >>> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:1060 >>> + return true; >> >> Why should we return true instead of false ? > > Beforeunload confirm pannel is for webpage(author) to ask that user really want to exit the current web page when requested navigation or close webview. > So, IMO, it looks reasonable that default behavior is true, that leaves the current page or closes webview. Got it !
Comment on attachment 264904 [details] Patch Clearing flags on attachment: 264904 Committed r192091: <http://trac.webkit.org/changeset/192091>
All reviewed patches have been landed. Closing bug.