Bug 150938 - Web Inspector: Toolbar "Inspect Node" button not highlighting when active
Summary: Web Inspector: Toolbar "Inspect Node" button not highlighting when active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-05 10:55 PST by Joseph Pecoraro
Modified: 2015-11-05 11:29 PST (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.58 KB, patch)
2015-11-05 10:57 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-11-05 10:55:52 PST 
* SUMMARY
Toolbar "Inspect Node" button not highlighting when active.

* STEPS TO REPRODUCE
1. Inspect this page
2. Click "Inspect Node" button in Toolbar
  => expected button to appear active, it did not
Comment 1 Joseph Pecoraro 2015-11-05 10:56:18 PST 
<rdar://problem/23414255>
Comment 2 Joseph Pecoraro 2015-11-05 10:57:26 PST 
Created attachment 264871 [details]
[PATCH] Proposed Fix
Comment 3 Simon Fraser (smfr) 2015-11-05 11:17:44 PST 
Could this breakage have been detected by regression testing?
Comment 4 WebKit Commit Bot 2015-11-05 11:28:31 PST 
Comment on attachment 264871 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264871

Committed r192063: <http://trac.webkit.org/changeset/192063>
Comment 5 WebKit Commit Bot 2015-11-05 11:28:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 BJ Burg 2015-11-05 11:29:42 PST 
(In reply to comment #3)
> Could this breakage have been detected by regression testing?

Currently, we do not have any test coverage for purely UI regressions like this one. It would be nice, but we'd need to have better user automation support to simulate clicking the element. And then we'd need to look at the computed style or something.

Preventing these regressions is high on my list of ways to reduce Web Inspector patch churn.