Bug 150918 - Web Inspector: Load markers persist in timeline ruler after resetting recording
Summary: Web Inspector: Load markers persist in timeline ruler after resetting recording
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-04 19:02 PST by Matt Baker
Modified: 2015-11-04 20:10 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (4.87 KB, patch)
2015-11-04 19:06 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2015-11-04 19:02:32 PST 
* SUMMARY
Load markers persist in timeline ruler after resetting recording. This doesn't apply to the current time marker, which is correctly reset to time zero.

* STEPS TO REPRODUCE
1. Inspector -> Timelines
2. Record a page reload
3. Stop the recording once the blue and red load markers appear (or let it stop on its own)
4. Reset the recording (Click the trashcan icon)
  => Current time marker resets to zero, but load markers remain
Comment 1 Radar WebKit Bug Importer 2015-11-04 19:03:01 PST 
<rdar://problem/23406324>
Comment 2 Matt Baker 2015-11-04 19:06:06 PST 
Created attachment 264834 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2015-11-04 19:19:05 PST 
Comment on attachment 264834 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264834&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        (WebInspector.OverviewTimelineView.prototype._recordingReset):
> +        Clears ruler markers on recording reset. Adds current time marker back.

Good find! When is the recording reset? Only the clear button and initial load? Is there any other way?
Comment 4 WebKit Commit Bot 2015-11-04 20:10:19 PST 
Comment on attachment 264834 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 264834

Committed r192050: <http://trac.webkit.org/changeset/192050>
Comment 5 WebKit Commit Bot 2015-11-04 20:10:23 PST 
All reviewed patches have been landed.  Closing bug.