Bug 150914 – Add runtime and compile time flags for enabling Web Animations API and model.

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Nikos Andronikos]

Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag for Web Animations implementation.

[Nikos Andronikos]

Created attachment 264831 [details]
Patch

[Benjamin Poulain]

Comment on attachment 264831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264831&action=review

r- due to the lack of explanation why the flag is disabled.

> Source/WTF/wtf/FeatureDefines.h:783
> +#define ENABLE_WEB_ANIMATIONS 0

Why is the compile time flag disabled?

The compile time flags are important for shipping WebKit. If anyone needs to ship before a feature is finished and safe, its flag can be disabled.

For development, you should aim at having the flag enabled as soon as possible. That way you can have tests running on all platforms ASAP.

[Nikos Andronikos]

(In reply to comment #2)
> Comment on attachment 264831 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264831&action=review
> 
> r- due to the lack of explanation why the flag is disabled.
> 
> > Source/WTF/wtf/FeatureDefines.h:783
> > +#define ENABLE_WEB_ANIMATIONS 0
> 
> Why is the compile time flag disabled?
> 
> The compile time flags are important for shipping WebKit. If anyone needs to
> ship before a feature is finished and safe, its flag can be disabled.
> 
> For development, you should aim at having the flag enabled as soon as
> possible. That way you can have tests running on all platforms ASAP.

My thinking was that we would enable it once there's something worthwhile to build. It looked to me like many features are disabled by default initially - e.g. ENABLE_ES6_GENERATORS and CSS_COMPOSITING.
I don't plan to wait too long to enable it, but would like to get some basics in first.

[Benjamin Poulain]

(In reply to comment #3)
> My thinking was that we would enable it once there's something worthwhile to
> build. It looked to me like many features are disabled by default initially
> - e.g. ENABLE_ES6_GENERATORS and CSS_COMPOSITING.
> I don't plan to wait too long to enable it, but would like to get some
> basics in first.

Ok, sounds good if you plan to enable it quickly.

[WebKit Commit Bot]

Comment on attachment 264831 [details]
Patch

Rejecting attachment 264831 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 264831 [details]
Patch

Clearing flags on attachment: 264831

Committed r192093: <http://trac.webkit.org/changeset/192093>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.