Bug 150910 – Modern IDB: Implement IDBIndex get/getKey/count requests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: Implement IDBIndex get/getKey/count requests

For the sake of patch reviewing, this initial run will already return empty values for get/getKey and always return 0 for count.

That is because indexes don't actually *index* yet.

But doing it this way first (returning the bum values) will make this patch much more reviewable, and make the "actually index things" patch much more reviewable.

[Brady Eidson]

Created attachment 264874 [details]
Patch v1

[Brady Eidson]

FWIW, after this is resolved, https://bugs.webkit.org/show_bug.cgi?id=150939 will make indexes actually index.

[Alex Christensen]

Comment on attachment 264874 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=264874&action=review

> Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:449
> +Ref<IDBRequest> IDBTransaction::requestGetValue(ScriptExecutionContext& context, IDBIndex& index, const IDBKeyRangeData& range)

This is just like requestGetKey.  Factor the common code out.

> Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp:52
> +    return { };

Will this be filled in soon?  Maybe a FIXME

[Brady Eidson]

(In reply to comment #3)
> Comment on attachment 264874 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264874&action=review
> 
> > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:449
> > +Ref<IDBRequest> IDBTransaction::requestGetValue(ScriptExecutionContext& context, IDBIndex& index, const IDBKeyRangeData& range)
> 
> This is just like requestGetKey.  Factor the common code out.
> 
> > Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp:52
> > +    return { };
> 
> Will this be filled in soon?  Maybe a FIXME

See https://bugs.webkit.org/show_bug.cgi?id=150910#c2

[Brady Eidson]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 264874 [details]
> > Patch v1
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=264874&action=review
> > 
> > > Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:449
> > > +Ref<IDBRequest> IDBTransaction::requestGetValue(ScriptExecutionContext& context, IDBIndex& index, const IDBKeyRangeData& range)
> > 
> > This is just like requestGetKey.  Factor the common code out.
> > 
> > > Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp:52
> > > +    return { };
> > 
> > Will this be filled in soon?  Maybe a FIXME
> 
> See https://bugs.webkit.org/show_bug.cgi?id=150910#c2

(But I'll put the fixme in code)

[Brady Eidson]

Created attachment 264876 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 264876 [details]
Patch for landing

Clearing flags on attachment: 264876

Committed r192068: <http://trac.webkit.org/changeset/192068>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.