Bug 150903 - Implement compareDouble in B3/Air
Summary: Implement compareDouble in B3/Air
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 150721 151009 152420
Blocks: 150279 150991
  Show dependency tree / graph
 
Reported: 2015-11-04 14:25 PST by Filip Pizlo
Modified: 2015-12-20 11:54 PST (History)
11 users (show)

See Also:

Attachments
the patch (7.84 KB, patch)
2015-12-18 18:35 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (7.83 KB, patch)
2015-12-19 12:45 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (7.79 KB, patch)
2015-12-19 12:47 PST, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-04 14:25:26 PST 
We need it.  It's OK if the MacroAssembler implements this with branches.
Comment 1 Filip Pizlo 2015-12-16 16:18:46 PST 
I'm implementing this as part of https://bugs.webkit.org/show_bug.cgi?id=152358.

*** This bug has been marked as a duplicate of bug 152358 ***
Comment 2 Filip Pizlo 2015-12-18 10:50:40 PST 
...
Comment 3 Filip Pizlo 2015-12-18 18:35:48 PST 
Created attachment 267674 [details]
the patch
Comment 4 Filip Pizlo 2015-12-19 12:45:10 PST 
Created attachment 267701 [details]
the patch
Comment 5 Filip Pizlo 2015-12-19 12:47:32 PST 
Created attachment 267702 [details]
the patch
Comment 6 Benjamin Poulain 2015-12-20 06:41:55 PST 
Comment on attachment 267702 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267702&action=review

> Source/JavaScriptCore/b3/testb3.cpp:9519
> +    RUN(testEqualDouble(PNaN, PNaN, false));

Can you please add (0, -0.)?
Comment 7 Filip Pizlo 2015-12-20 07:53:01 PST 
(In reply to comment #6)
> Comment on attachment 267702 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267702&action=review
> 
> > Source/JavaScriptCore/b3/testb3.cpp:9519
> > +    RUN(testEqualDouble(PNaN, PNaN, false));
> 
> Can you please add (0, -0.)?

Good idea!
Comment 8 Filip Pizlo 2015-12-20 11:54:29 PST 
Landed in http://trac.webkit.org/changeset/194320