Bug 150901 - Fix crashing and flaky UIScriptController-based tests in fast/events/ios
Summary: Fix crashing and flaky UIScriptController-based tests in fast/events/ios
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: InRadar
Depends on:
Reported: 2015-11-04 13:31 PST by Wenson Hsieh
Modified: 2015-11-04 15:35 PST (History)
4 users (show)

See Also:

Patch (10.71 KB, patch)
2015-11-04 13:57 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2015-11-04 13:31:53 PST
Fix crashing and flaky tests in LayoutTests/fast/events/ios. One of the main causes of our crashes is that zooming and keyboard callbacks that have been set by previous tests are not cleared before running the next test, so code from the previous test may be executed during the next test if the test does not set the callback to something else. This causes us to access the previous deallocated UIScriptController and crash.
Comment 1 Wenson Hsieh 2015-11-04 13:39:44 PST
Comment 2 Wenson Hsieh 2015-11-04 13:57:22 PST
Created attachment 264810 [details]
Comment 3 WebKit Commit Bot 2015-11-04 15:35:41 PST
Comment on attachment 264810 [details]

Clearing flags on attachment: 264810

Committed r192039: <http://trac.webkit.org/changeset/192039>
Comment 4 WebKit Commit Bot 2015-11-04 15:35:44 PST
All reviewed patches have been landed.  Closing bug.