Bug 150892 – Remove bogus global internal functions for properties and prototype retrieval

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

Remove bogus global internal functions for properties and prototype retrieval

[Xabier Rodríguez Calvar]

Created attachment 264791 [details]
Patch

[Build Bot]

Comment on attachment 264791 [details]
Patch

Attachment 264791 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/381945

New failing tests:
animations/multiple-backgrounds.html

[Build Bot]

Created attachment 264792 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> New failing tests:
> animations/multiple-backgrounds.html

This seems to be unrelated.

[Mark Lam]

LGTM too.

[Darin Adler]

Comment on attachment 264791 [details]
Patch

Ideally we would make a test that covers this. I know it seems crazy, but if there was any web-visible behavior this was causing, we really want a test case, not just code inspection, to make sure we don’t have something strange like this. Even if the test is specific to these private function names.

[Darin Adler]

If there was nothing web visible, then seems like this is just an internal cleanup and it makes sense that there is no test.

[Xabier Rodríguez Calvar]

(In reply to comment #7)
> If there was nothing web visible, then seems like this is just an internal
> cleanup and it makes sense that there is no test.

Thanks for the r+. Though I was planning to set cq+ tomorrow because I'll leave in less than an hour, I see that you did it yourself. I don't think this will cause any trouble though. If it does, please roll the patch out.

[Xabier Rodríguez Calvar]

(In reply to comment #8)
> > If there was nothing web visible, then seems like this is just an internal
> > cleanup and it makes sense that there is no test.

And answering your comment, no, it shouldn't create any web visible effect. It's internal functions we are dealing with.

[WebKit Commit Bot]

Comment on attachment 264791 [details]
Patch

Clearing flags on attachment: 264791

Committed r192024: <http://trac.webkit.org/changeset/192024>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.