RESOLVED FIXED 150889
[GStreamer] Use MainThreadNotifier to send notifications to main thread in TrackPrivateGStreamer 
https://bugs.webkit.org/show_bug.cgi?id=150889
Summary [GStreamer] Use MainThreadNotifier to send notifications to main thread in Tr...
Carlos Garcia Campos
Reported 2015-11-04 03:30:26 PST
Instead of the GThreadSafeMainLoopSources.
Attachments
Patch (11.83 KB, patch)
2015-11-04 03:32 PST, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
Updated patch (10.99 KB, patch)
2015-11-06 05:10 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-11-04 03:32:49 PST
Created attachment 264787 [details] Patch
WebKit Commit Bot
Comment 2 2015-11-04 03:34:11 PST
Attachment 264787 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:84: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:104: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:82: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:92: More than one command on the same line [whitespace/newline] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2015-11-04 03:36:21 PST
This is not going to build, because it depends on #150888
Zan Dobersek
Comment 4 2015-11-06 05:05:23 PST
Comment on attachment 264787 [details] Patch All the uses of MainThreadNotifier<>::notify() need updating, otherwise looks fine.
Carlos Garcia Campos
Comment 5 2015-11-06 05:10:07 PST
Created attachment 264935 [details] Updated patch
WebKit Commit Bot
Comment 6 2015-11-06 05:11:45 PST
Attachment 264935 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:80: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:97: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:78: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:84: More than one command on the same line [whitespace/newline] [4] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 7 2015-11-06 06:18:21 PST
Committed r192101: <http://trac.webkit.org/changeset/192101>
Note You need to log in before you can comment on or make changes to this bug.