Bug 150883 – Ruby base ending in tatechuyoko forces a line break before the tatechuyoko

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Ruby base ending in tatechuyoko forces a line break before the tatechuyoko

[Myles C. Maxfield]

Created attachment 264770 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 264770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264770&action=review

> Source/WebCore/rendering/RenderCombineText.cpp:64
> +        return !length ? 0 : font.size();

Maybe I should ASSERT() that the length is either 0 or 1.

[Build Bot]

Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/380160

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html

[Build Bot]

Created attachment 264771 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/380196

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html

[Build Bot]

Created attachment 264773 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/380201

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html

[Build Bot]

Created attachment 264774 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Myles C. Maxfield]

Created attachment 264778 [details]
Patch

[Build Bot]

Comment on attachment 264778 [details]
Patch

Attachment 264778 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/380565

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html

[Build Bot]

Created attachment 264779 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 264778 [details]
Patch

Attachment 264778 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/380569

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html

[Build Bot]

Created attachment 264780 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Darin Adler]

Comment on attachment 264778 [details]
Patch

I imagine there are results for this other than platform/mac that need to be updated. Like older versions of mac, for example:

  fast/text/international/text-combine-image-test.html [ Failure ]
  fast/text/tatechuyoko.html [ Failure ]

Really would be nice to change these into ref tests if we can.

[Myles C. Maxfield]

Committed r192042: <http://trac.webkit.org/changeset/192042>

[Myles C. Maxfield]

<rdar://problem/21926114>