Bug 150883 - Ruby base ending in tatechuyoko forces a line break before the tatechuyoko
Summary: Ruby base ending in tatechuyoko forces a line break before the tatechuyoko
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-03 22:14 PST by Myles C. Maxfield
Modified: 2015-11-05 11:01 PST (History)
12 users (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2015-11-03 22:15 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (1.16 MB, application/zip)
2015-11-03 22:51 PST, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-mavericks (972.20 KB, application/zip)
2015-11-03 22:59 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (1016.52 KB, application/zip)
2015-11-03 23:02 PST, Build Bot
no flags Details
Patch (9.91 KB, patch)
2015-11-04 00:20 PST, Myles C. Maxfield
darin: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (969.99 KB, application/zip)
2015-11-04 01:04 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (1022.84 KB, application/zip)
2015-11-04 01:09 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-11-03 22:14:22 PST
Ruby base ending in tatechuyoko forces a line break before the tatechuyoko
Comment 1 Myles C. Maxfield 2015-11-03 22:15:22 PST
Created attachment 264770 [details]
Patch
Comment 2 Myles C. Maxfield 2015-11-03 22:16:26 PST
Comment on attachment 264770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264770&action=review

> Source/WebCore/rendering/RenderCombineText.cpp:64
> +        return !length ? 0 : font.size();

Maybe I should ASSERT() that the length is either 0 or 1.
Comment 3 Build Bot 2015-11-03 22:51:51 PST
Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/380160

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html
Comment 4 Build Bot 2015-11-03 22:51:55 PST
Created attachment 264771 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2015-11-03 22:58:57 PST
Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/380196

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html
Comment 6 Build Bot 2015-11-03 22:59:01 PST
Created attachment 264773 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Build Bot 2015-11-03 23:02:22 PST
Comment on attachment 264770 [details]
Patch

Attachment 264770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/380201

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html
Comment 8 Build Bot 2015-11-03 23:02:25 PST
Created attachment 264774 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 Myles C. Maxfield 2015-11-04 00:20:21 PST
Created attachment 264778 [details]
Patch
Comment 10 Build Bot 2015-11-04 01:04:45 PST
Comment on attachment 264778 [details]
Patch

Attachment 264778 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/380565

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html
Comment 11 Build Bot 2015-11-04 01:04:50 PST
Created attachment 264779 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 12 Build Bot 2015-11-04 01:08:55 PST
Comment on attachment 264778 [details]
Patch

Attachment 264778 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/380569

New failing tests:
fast/text/tatechuyoko.html
fast/text/international/text-combine-image-test.html
Comment 13 Build Bot 2015-11-04 01:09:00 PST
Created attachment 264780 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 14 Darin Adler 2015-11-04 09:25:58 PST
Comment on attachment 264778 [details]
Patch

I imagine there are results for this other than platform/mac that need to be updated. Like older versions of mac, for example:

  fast/text/international/text-combine-image-test.html [ Failure ]
  fast/text/tatechuyoko.html [ Failure ]

Really would be nice to change these into ref tests if we can.
Comment 15 Myles C. Maxfield 2015-11-04 16:27:19 PST
Committed r192042: <http://trac.webkit.org/changeset/192042>
Comment 16 Myles C. Maxfield 2015-11-05 11:01:38 PST
<rdar://problem/21926114>