Patch forthcoming.
Created attachment 264765 [details] the patch
Attachment 264765 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/b3/testb3.cpp:1778: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1779: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1781: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1794: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1794: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/b3/testb3.cpp:1795: Consider using CHECK_EQ instead of CHECK(a == b) [readability/check] [2] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 264765 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=264765&action=review r=me > Source/JavaScriptCore/b3/B3LowerToAir.cpp:486 > + case ValueRep::SomeRegister: What's the difference between "Register" and "SomeRegister"? > Source/JavaScriptCore/b3/testb3.cpp:1781 > + CHECK(params.reps[0].value() == 1); I'm a bit confused here, why is this "1"?
(In reply to comment #4) > Comment on attachment 264765 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264765&action=review > > r=me > > > Source/JavaScriptCore/b3/B3LowerToAir.cpp:486 > > + case ValueRep::SomeRegister: > > What's the difference between "Register" and "SomeRegister"? SomeRegister is a constraint requesting that the value ends up in a register. It means that it can end up with any register that matches the value's type (GPR for int, FPR for double). > > > Source/JavaScriptCore/b3/testb3.cpp:1781 > > + CHECK(params.reps[0].value() == 1); > > I'm a bit confused here, why is this "1"? A Check is a stackmap, so it must provide a ValueRep for each operand. The ValueRep only needs to be valid on the path where the Check "failed", i.e. its predicate was true. By convention, if you do: Check(x, y) Then we claim that x's value was 1. Note that y is optional. For y, we will provide an actual value recovery. The reason why we don't provide an honest recovery of x is that it's not actually useful for most users of Check, and it just so happens to 1 is kind of correct.
Landed in http://trac.webkit.org/changeset/192035