Bug 150868 - Modern IDB: Fill out IDBIndex, create MemoryIndex in backing store
Summary: Modern IDB: Fill out IDBIndex, create MemoryIndex in backing store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency treegraph
 
Reported: 2015-11-03 16:24 PST by Brady Eidson
Modified: 2015-11-04 16:41 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (101.27 KB, patch)
2015-11-03 16:28 PST, Brady Eidson
achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.06 MB, application/zip)
2015-11-03 17:01 PST, Build Bot
no flags Details
Patch for landing (95.69 KB, patch)
2015-11-03 21:57 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-11-03 16:24:01 PST
Modern IDB: Fill out IDBIndex, create MemoryIndex in backing store
Comment 1 Brady Eidson 2015-11-03 16:28:03 PST
Created attachment 264752 [details]
Patch v1
Comment 2 Build Bot 2015-11-03 17:01:42 PST
Comment on attachment 264752 [details]
Patch v1

Attachment 264752 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/379073

New failing tests:
storage/indexeddb/keypath-basics.html
Comment 3 Build Bot 2015-11-03 17:01:45 PST
Created attachment 264758 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 4 Alex Christensen 2015-11-03 17:06:34 PST
Comment on attachment 264752 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=264752&action=review

Test "failure" might need to change test.

> Source/WebCore/ChangeLog:142
> +2015-11-03  Brady Eidson  <beidson@apple.com>

You have two ChangeLog entries :(
Comment 5 Brady Eidson 2015-11-03 21:57:36 PST
Created attachment 264769 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-11-03 23:17:24 PST
Comment on attachment 264769 [details]
Patch for landing

Clearing flags on attachment: 264769

Committed r192014: <http://trac.webkit.org/changeset/192014>