Bug 150866 - Rename DFG's compileAdd to compileArithAdd.
Summary: Rename DFG's compileAdd to compileArithAdd.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-03 16:06 PST by Mark Lam
Modified: 2015-11-03 17:01 PST (History)
1 user (show)

See Also:

Attachments
the patch. (3.24 KB, patch)
2015-11-03 16:09 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2015-11-03 16:06:02 PST 
The function is supposed to only generate code to do arithmetic on numeric types.  Naming it compileArithAdd() is more accurate, and is consistent with the name of the node it emits code for (i.e. ArithAdd) as well as other compiler functions for analogous operations e.g. compileArithSub.
Comment 1 Mark Lam 2015-11-03 16:09:30 PST 
Created attachment 264748 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-11-03 17:01:32 PST 
Comment on attachment 264748 [details]
the patch.

Clearing flags on attachment: 264748

Committed r192000: <http://trac.webkit.org/changeset/192000>
Comment 3 WebKit Commit Bot 2015-11-03 17:01:35 PST 
All reviewed patches have been landed.  Closing bug.