Bug 150851 - [MediaStream] A RealtimeMediaSource should begin producing data automatically
Summary: [MediaStream] A RealtimeMediaSource should begin producing data automatically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-11-03 13:12 PST by Eric Carlson
Modified: 2016-01-04 13:15 PST (History)
4 users (show)

See Also:


Attachments
Proposed patch. (13.28 KB, patch)
2015-11-03 13:30 PST, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch for landing. (13.24 KB, patch)
2015-11-04 09:36 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-11-03 13:12:48 PST
A realtime media source should begin producing data when it is added to a stream. Remove RealtimeMediaSource::setEnabled and RealtimeMediaSource::enabled and associated callbacks because a source does not have an "enabled" state, only "muted".
Comment 1 Radar WebKit Bug Importer 2015-11-03 13:14:02 PST
<rdar://problem/23380636>
Comment 2 Eric Carlson 2015-11-03 13:30:29 PST
Created attachment 264718 [details]
Proposed patch.
Comment 3 Adam Bergkvist 2015-11-04 04:13:54 PST
Looks good to me
Comment 4 Jer Noble 2015-11-04 09:22:16 PST
Comment on attachment 264718 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=264718&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:456
>  
> +    characteristicsChanged();
>      m_readyState = readyState;
>  

Do you maybe want to throw the characteristicsChanged() notification _after_ updating the ready state? Because if anyone checks ready state from within that call, they'll see it as unchanged.
Comment 5 Eric Carlson 2015-11-04 09:36:13 PST
Created attachment 264793 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2015-11-04 10:56:01 PST
Comment on attachment 264793 [details]
Patch for landing.

Clearing flags on attachment: 264793

Committed r192028: <http://trac.webkit.org/changeset/192028>