Bug 150831 - B3::Stackmap should be a superclass of B3::PatchpointValue and B3::CheckValue rather than being one of their members
Summary: B3::Stackmap should be a superclass of B3::PatchpointValue and B3::CheckValue...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency tree / graph
 
Reported: 2015-11-02 20:35 PST by Filip Pizlo
Modified: 2015-11-03 16:14 PST (History)
11 users (show)

See Also:

Attachments
it's a start (9.57 KB, patch)
2015-11-02 20:36 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (54.79 KB, patch)
2015-11-03 11:06 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (67.76 KB, patch)
2015-11-03 11:33 PST, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-11-02 20:35:34 PST 
This will simplify things a lot.
Comment 1 Filip Pizlo 2015-11-02 20:36:37 PST 
Created attachment 264659 [details]
it's a start
Comment 2 Filip Pizlo 2015-11-03 11:06:38 PST 
Created attachment 264700 [details]
more

Of course it doesn't compile yet.
Comment 3 Filip Pizlo 2015-11-03 11:33:22 PST 
Created attachment 264703 [details]
the patch
Comment 4 WebKit Commit Bot 2015-11-03 11:36:16 PST 
Attachment 264703 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3MemoryValue.h:68:  The parameter name "comma" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/b3/testb3.cpp:1214:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Benjamin Poulain 2015-11-03 15:20:52 PST 
Comment on attachment 264703 [details]
the patch

rs=me
Comment 6 Filip Pizlo 2015-11-03 16:14:39 PST 
Landed in http://trac.webkit.org/changeset/191993