Clean up NETWORK_SESSION code after r191848
Created attachment 264652 [details] Patch
Fixed Darin's comment in https://bugs.webkit.org/show_bug.cgi?id=150742
Comment on attachment 264652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264652&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > + auto size = buffer->size(); > + sharedDidReceiveBuffer(WTF::move(buffer), size); This is not clean up; it’s fixing a potentially serious bug.
Comment on attachment 264652 [details] Patch Clearing flags on attachment: 264652 Committed r191942: <http://trac.webkit.org/changeset/191942>
All reviewed patches have been landed. Closing bug.
(In reply to comment #3) > Comment on attachment 264652 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264652&action=review > > > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:474 > > - sharedDidReceiveBuffer(WTF::move(buffer), buffer->size()); > > + auto size = buffer->size(); > > + sharedDidReceiveBuffer(WTF::move(buffer), size); > > This is not clean up; it’s fixing a potentially serious bug. I agree. I think this should've caused crashes, but it didn't. I also think we should remove the size parameter because it's not really used.