Bug 150795 - Fix the FTL JIT build with system LLVM on Linux
Summary: Fix the FTL JIT build with system LLVM on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 143605
  Show dependency treegraph
 
Reported: 2015-11-02 05:38 PST by Csaba Osztrogonác
Modified: 2015-11-02 08:25 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.45 KB, patch)
2015-11-02 05:42 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
Patch for landing (4.85 KB, patch)
2015-11-02 07:36 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-02 05:38:27 PST
Now it builds fine with LLVM jhbuild modules, but not with system LLVM. Let's fix it.
Comment 1 Csaba Osztrogonác 2015-11-02 05:40:33 PST
--system-libs option was introduced in LLVM 3.6, let's use it to add system
libraries instead of hard coding them to CMakeLists.txt

Additionally we will need libedit-dev package to be able link libedit.a .
Comment 2 Csaba Osztrogonác 2015-11-02 05:42:58 PST
Created attachment 264577 [details]
Patch
Comment 3 Michael Catanzaro 2015-11-02 07:12:12 PST
Please also add the Arch package libedit and the Fedora package libedit-devel.

In the future, you can search out these names at:

https://www.archlinux.org/packages/
https://admin.fedoraproject.org/pkgdb/
Comment 4 Csaba Osztrogonác 2015-11-02 07:35:45 PST
(In reply to comment #3)
> Please also add the Arch package libedit and the Fedora package
> libedit-devel.
> 
> In the future, you can search out these names at:
> 
> https://www.archlinux.org/packages/
> https://admin.fedoraproject.org/pkgdb/

Oops, sorry. I'll add them before landing.
Comment 5 Csaba Osztrogonác 2015-11-02 07:36:05 PST
Created attachment 264587 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2015-11-02 08:25:32 PST
Comment on attachment 264587 [details]
Patch for landing

Clearing flags on attachment: 264587

Committed r191889: <http://trac.webkit.org/changeset/191889>
Comment 7 WebKit Commit Bot 2015-11-02 08:25:35 PST
All reviewed patches have been landed.  Closing bug.