Bug 150793 - Clean up ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep minimal set of them
Summary: Clean up ENABLE(ES6_ARROWFUNCTION_SYNTAX) ifdefs and keep minimal set of them
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P1 Blocker
Assignee: Yusuke Suzuki
Depends on:
Blocks: 150769
  Show dependency treegraph
Reported: 2015-11-02 03:13 PST by Csaba Osztrogonác
Modified: 2015-11-03 02:37 PST (History)
3 users (show)

See Also:

Patch (3.87 KB, patch)
2015-11-02 08:00 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-11-02 03:13:01 PST
https://trac.webkit.org/changeset/191875 broke the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build:

../../Source/JavaScriptCore/parser/Parser.cpp: In member function 'bool JSC::Parser<T>::parseFunctionInfo(TreeBuilder&, JSC::FunctionRequirements, JSC::SourceParseMode, bool, JSC::ConstructorKind, JSC::SuperBinding, int, JSC::ParserFunctionInfo<TreeBuilder>&, JSC::Parser<T>::FunctionDefinitionType)':
../../Source/JavaScriptCore/parser/Parser.cpp:1695:25: error: 'ARROWFUNCTION' was not declared in this scope

( I don't have any time to investigate this regression, feel free to pick it up. )
Comment 1 Yusuke Suzuki 2015-11-02 07:08:18 PST
I'll check this.
Comment 2 Yusuke Suzuki 2015-11-02 07:19:59 PST
Thanks! This is my fault. I accidentally used ARROWFUNCTION token without ifdef.
I'll create the patch once I returned home (in one hour).
Comment 3 Yusuke Suzuki 2015-11-02 07:54:05 PST
I'll keep the minimal ENABLE(ES6_ARROWFUNCTION_SYNTAX) and clean up many ifdefs!
Comment 4 Yusuke Suzuki 2015-11-02 08:00:21 PST
Created attachment 264588 [details]
Comment 5 Yusuke Suzuki 2015-11-02 08:08:23 PST
One difference from the original one is, this patch enables lexing `=>` token. But the parser does not use it for any reductions. This token is just rejected.
Comment 6 Yusuke Suzuki 2015-11-03 01:49:17 PST
Comment on attachment 264588 [details]

Comment 7 WebKit Commit Bot 2015-11-03 02:37:13 PST
Comment on attachment 264588 [details]

Clearing flags on attachment: 264588

Committed r191946: <http://trac.webkit.org/changeset/191946>
Comment 8 WebKit Commit Bot 2015-11-03 02:37:16 PST
All reviewed patches have been landed.  Closing bug.