WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
150757
[GTK] Use RunLoop::Timer in PluginInfoCache
https://bugs.webkit.org/show_bug.cgi?id=150757
Summary
[GTK] Use RunLoop::Timer in PluginInfoCache
Carlos Garcia Campos
Reported
2015-10-31 01:36:41 PDT
We use a GMainLoopSource to save the cache in an idle.
Attachments
Patch
(4.17 KB, patch)
2015-10-31 01:41 PDT
,
Carlos Garcia Campos
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2015-10-31 01:41:58 PDT
Created
attachment 264474
[details]
Patch
Carlos Garcia Campos
Comment 2
2015-10-31 01:42:34 PDT
This one also depends on patch attached to
bug #150754
to build
Darin Adler
Comment 3
2015-10-31 14:43:42 PDT
Comment on
attachment 264474
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=264474&action=review
> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50 > + m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE);
Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority'
Darin Adler
Comment 4
2015-10-31 14:43:58 PDT
Comment on
attachment 264474
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=264474&action=review
>> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50 >> + m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE); > > Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority'
Oh, I see now.
Carlos Garcia Campos
Comment 5
2015-11-01 01:34:36 PST
Committed
r191855
: <
http://trac.webkit.org/changeset/191855
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug