Bug 150757 - [GTK] Use RunLoop::Timer in PluginInfoCache
Summary: [GTK] Use RunLoop::Timer in PluginInfoCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 150754
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-31 01:36 PDT by Carlos Garcia Campos
Modified: 2015-11-01 01:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.17 KB, patch)
2015-10-31 01:41 PDT, Carlos Garcia Campos 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-10-31 01:36:41 PDT 
We use a GMainLoopSource to save the cache in an idle.
Comment 1 Carlos Garcia Campos 2015-10-31 01:41:58 PDT 
Created attachment 264474 [details]
Patch
Comment 2 Carlos Garcia Campos 2015-10-31 01:42:34 PDT 
This one also depends on patch attached to bug #150754 to build
Comment 3 Darin Adler 2015-10-31 14:43:42 PDT 
Comment on attachment 264474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264474&action=review

> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50
> +    m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE);

Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority'
Comment 4 Darin Adler 2015-10-31 14:43:58 PDT 
Comment on attachment 264474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264474&action=review

>> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:50
>> +    m_saveToFileIdle.setPriority(G_PRIORITY_DEFAULT_IDLE);
> 
> Bot says: error: 'class WTF::RunLoop::Timer<WebKit::PluginInfoCache>' has no member named 'setPriority'

Oh, I see now.
Comment 5 Carlos Garcia Campos 2015-11-01 01:34:36 PST 
Committed r191855: <http://trac.webkit.org/changeset/191855>