Bug 150732 – Use convenience function in sandbox profile

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brent Fulgham]

This bug cleans up one of the sandbox profiles by using a convenience function to define the proper logging setup, rather than manually specifying each piece of the log directory permissions required.

[Brent Fulgham]

Created attachment 264412 [details]
Patch

[Brent Fulgham]

<rdar://problem/23287894>

[Geoffrey Garen]

Comment on attachment 264412 [details]
Patch

Is awd-log-directory available on older OS's?

[Brent Fulgham]

(In reply to comment #3)
> Comment on attachment 264412 [details]
> Patch
> 
> Is awd-log-directory available on older OS's?

This profile is only used on iOS. The function was added in iOS 9, so it's really only usable on current builds. But I'm not sure if we support building WebKit on older iOS revisions.

[Alexey Proskuryakov]

Comment on attachment 264412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review

> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84
> -(allow mach-lookup (global-name "com.apple.awdd"))

Is this unnecessary?

[Brent Fulgham]

Comment on attachment 264412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review

>> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84
>> -(allow mach-lookup (global-name "com.apple.awdd"))
> 
> Is this unnecessary?

It's done as part of the (awd-log-directory ...) function.

[WebKit Commit Bot]

Comment on attachment 264412 [details]
Patch

Clearing flags on attachment: 264412

Committed r191872: <http://trac.webkit.org/changeset/191872>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.