Bug 150718 - Modern IDB: Support IDBObjectStore.get() for IDBKeyRanges
Summary: Modern IDB: Support IDBObjectStore.get() for IDBKeyRanges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-10-30 08:55 PDT by Brady Eidson
Modified: 2015-10-30 17:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (37.54 KB, patch)
2015-10-30 10:08 PDT, Brady Eidson 		beidson: review-
Details | Formatted Diff | Diff
patch v2 (41.25 KB, patch)
2015-10-30 10:36 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-10-30 08:55:55 PDT 
Modern IDB: Support IDBObjectStore.get() for IDBKeyRanges
Comment 1 Brady Eidson 2015-10-30 10:08:54 PDT 
Created attachment 264399 [details]
Patch v1
Comment 2 Brady Eidson 2015-10-30 10:09:29 PDT 
Comment on attachment 264399 [details]
Patch v1

Forgot to add the results for the test
Comment 3 Brady Eidson 2015-10-30 10:36:20 PDT 
Created attachment 264401 [details]
patch v2
Comment 4 Alex Christensen 2015-10-30 10:53:17 PDT 
Comment on attachment 264401 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=264401&action=review

> LayoutTests/storage/indexeddb/modern/get-keyrange.html:74
> +    

Add some tests with null, strings, arrays, NaN, {}, etc.

> Source/WebCore/Modules/indexeddb/IDBKeyRangeData.cpp:39
> +    , lowerOpen(false)

lowerOpen { false } in header instead of three other copies.
Comment 5 Brady Eidson 2015-10-30 17:19:15 PDT 
https://trac.webkit.org/changeset/191832