Bug 150705 - [EFL] Add try_close API to handle beforeunload event
Summary: [EFL] Add try_close API to handle beforeunload event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-29 19:51 PDT by Ryuan Choi
Modified: 2015-11-05 01:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.31 KB, patch)
2015-10-29 20:01 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (6.22 KB, patch)
2015-11-03 23:40 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-10-29 19:51:41 PDT 
In order to show beforeunload confirm panel when closing web page which contains beforeunload event,
we should call tryClose.
Comment 1 Ryuan Choi 2015-10-29 20:01:36 PDT 
Created attachment 264375 [details]
Patch
Comment 2 Gyuyoung Kim 2015-11-03 22:11:24 PST 
Comment on attachment 264375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264375&action=review

LGTM except for trivial nits.

> Source/WebKit2/ChangeLog:9
> +        except on termination.

s/except on/instead of/g ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129
> +void ewk_view_try_close(Evas_Object* ewkView)

Add *const* keyword.
Comment 3 Ryuan Choi 2015-11-03 23:40:47 PST 
Created attachment 264776 [details]
Patch
Comment 4 Ryuan Choi 2015-11-03 23:42:52 PST 
(In reply to comment #2)
> Comment on attachment 264375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264375&action=review
> 
> LGTM except for trivial nits.
> 
> > Source/WebKit2/ChangeLog:9
> > +        except on termination.
> 
> s/except on/instead of/g ?
> 
I removed this confusing sentence.

> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:129
> > +void ewk_view_try_close(Evas_Object* ewkView)
> 
> Add *const* keyword.

I am not sure, this api has a behavior which calls popup or close callback.
Comment 5 WebKit Commit Bot 2015-11-05 01:30:34 PST 
Comment on attachment 264776 [details]
Patch

Clearing flags on attachment: 264776

Committed r192053: <http://trac.webkit.org/changeset/192053>
Comment 6 WebKit Commit Bot 2015-11-05 01:30:38 PST 
All reviewed patches have been landed.  Closing bug.