Bug 150698 - Animometer computes frame rate incorrectly
Summary: Animometer computes frame rate incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-29 16:22 PDT by Simon Fraser (smfr)
Modified: 2015-10-29 18:29 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2015-10-29 17:26 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2015-10-29 16:22:56 PDT
The Animator.animate() function tests if (this._frameCount == this._dropFrameCount) before incrementing this._frameCount, causing it to store the wrong this._measureTimeOffset. This causes it to report 90fps when it's actually doing 60fps.
Comment 1 Simon Fraser (smfr) 2015-10-29 17:26:43 PDT
Created attachment 264367 [details]
Patch
Comment 2 Said Abou-Hallawa 2015-10-29 17:33:22 PDT
unofficial r=me.
Comment 3 WebKit Commit Bot 2015-10-29 18:29:12 PDT
Comment on attachment 264367 [details]
Patch

Clearing flags on attachment: 264367

Committed r191768: <http://trac.webkit.org/changeset/191768>
Comment 4 WebKit Commit Bot 2015-10-29 18:29:16 PDT
All reviewed patches have been landed.  Closing bug.