Bug 150697 – Web Inspector: Make use of other Timer details in Timeline (timeout, singleShot)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Make use of other Timer details in Timeline (timeout, singleShot).

Currently we just ignore this data that we get from the backend. We should show something.

[Joseph Pecoraro]

Created attachment 264349 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 264350 [details]
[IMAGE] Timer Details - Scripts Timeline Content View

[Joseph Pecoraro]

Created attachment 264352 [details]
[IMAGE] Timer Details - Resource Content View

[Joseph Pecoraro]

Created attachment 264353 [details]
[IMAGE] Timer Details - Overview (SourceCodeTimelines)

[Timothy Hatcher]

Comment on attachment 264349 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264349&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:98
> +                    alternateSubtitle.textContent = timelineRecord.details.timeout + "ms";

The time makes me think that is how long it took to install. I'm not sure what would help that…

You should use Number.secondsToString(timelineRecord.details.timeout / 1000) or this needs localized as a format string.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:100
> +                }
> +                iconStyleClass = WebInspector.TimelineRecordTreeElement.TimerRecordIconStyleClass;

Newline.

[Joseph Pecoraro]

Created attachment 264356 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 264357 [details]
[IMAGE] New Approach

[WebKit Commit Bot]

Comment on attachment 264356 [details]
[PATCH] Proposed Fix

Rejecting attachment 264356 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 264356, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 191761 = 8e313ac7fdcd82bfe4d099a0f4688256201b9f3e
r191762 = b94efe42ea543d6de5f57c02e40ce1d95b4fa0cd
r191763 = b57173951d91f001cb813eb81584c9b20f56f3c1
r191764 = ea673c58d284d8ff77a9617e47e5c4f31a7ce9d5
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/355797

[WebKit Commit Bot]

Comment on attachment 264356 [details]
[PATCH] Proposed Fix

Rejecting attachment 264356 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 264356, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Original content of Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js mismatches at /Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply line 283.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 255 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/355811

[Joseph Pecoraro]

http://trac.webkit.org/changeset/191770

[Radar WebKit Bug Importer]

<rdar://problem/24634099>