Bug 150696 – [ES6] Add support for toStringTag

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Keith Miller]

[ES6] Add support for toStringTag

[Keith Miller]

Created attachment 264354 [details]
Patch

[Geoffrey Garen]

Comment on attachment 264354 [details]
Patch

r=me

[Build Bot]

Comment on attachment 264354 [details]
Patch

Attachment 264354 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/355371

New failing tests:
http/tests/security/cross-frame-access-object-setPrototypeOf.html
http/tests/security/cross-frame-access-custom.html
http/tests/history/cross-origin-replace-history-object-child.html

[Build Bot]

Created attachment 264360 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 264354 [details]
Patch

Attachment 264354 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/355362

New failing tests:
http/tests/security/cross-frame-access-history-get.html
http/tests/security/cross-frame-access-object-setPrototypeOf.html
http/tests/security/cross-frame-access-custom.html
http/tests/history/cross-origin-replace-history-object-child.html

[Build Bot]

Created attachment 264361 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 264354 [details]
Patch

Attachment 264354 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/355402

New failing tests:
http/tests/security/cross-frame-access-history-get.html
http/tests/security/cross-frame-access-object-setPrototypeOf.html
http/tests/security/cross-frame-access-custom.html
http/tests/history/cross-origin-replace-history-object-child.html

[Build Bot]

Created attachment 264362 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Keith Miller]

Created attachment 264364 [details]
Benchmark results

Benchmark results look neutral.

[Keith Miller]

Failing tests are kosher. The cross domain issues are just because we are attempting to get the Symbol.toStringTag from a different window and should be blocked anyway. I'll update the expected files.

[Keith Miller]

Committed r191815: <http://trac.webkit.org/changeset/191815>

[Ryan Haddad]

FYI ** The following JSC stress test failures have been introduced:
	es6.yaml/es6/well-known_symbols_Symbol.toStringTag.js.default
	es6.yaml/es6/well-known_symbols_Symbol.toStringTag_misc._built-ins.js.default

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/849/steps/jscore-test/logs/stdio>

[Keith Miller]

(In reply to comment #12)
> FYI ** The following JSC stress test failures have been introduced:
> 	es6.yaml/es6/well-known_symbols_Symbol.toStringTag.js.default
> 	es6.yaml/es6/well-known_symbols_Symbol.toStringTag_misc._built-ins.js.
> default
> 
> <https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/849/steps/jscore-
> test/logs/stdio>

Looking.

[Keith Miller]

Test failures should be fixed in <http://trac.webkit.org/changeset/191821>. I forgot to mark those tests as passing.

[Ryan Haddad]

(In reply to comment #14)
> Test failures should be fixed in <http://trac.webkit.org/changeset/191821>.
> I forgot to mark those tests as passing.

Cool. Thanks for taking a look!

[Alexey Proskuryakov]

32-bit JSC tests have been failing with strange crashes every time after this patch:

https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/13823/steps/webkit-32bit-jsc-test/logs/stdio

https://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/13852/steps/webkit-32bit-jsc-test/logs/stdio

I'm going to try rolling out to see if that helps.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 150781

[Alexey Proskuryakov]

Re-landed in r191864, as this wasn't the culprit. I wonder what was!

[Darin Adler]

(In reply to comment #18)
> Re-landed in r191864, as this wasn't the culprit. I wonder what was!

Re-landing this did introduce test failures.

Regressions: Unexpected text-only failures (3)
  http/tests/history/cross-origin-replace-history-object-child.html [ Failure ]
  http/tests/security/cross-frame-access-custom.html [ Failure ]
  http/tests/security/cross-frame-access-object-setPrototypeOf.html [ Failure ]

I think this may have to be rolled out after all. Could someone please investigate?

[Darin Adler]

And EWS shows those same failures, so we should not have ignored them in EWS!

[Darin Adler]

Oh, wait, you say those failures are actually progressions.

My new question then is: Why haven’t the new expected results been landed yet?

[Darin Adler]

Looks like when Alexey re-landed in r191864, the changes to http/tests expected results didn’t land.

[Darin Adler]

I tried to fix things in http://trac.webkit.org/changeset/191869

[Chris Dumez]

Significant Dromaeo regression after this: rdar://problem/23365738