Bug 150691 – Web Inspector: Display console.timeStamp(title) title in timeline markers

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Display console.timeStamp(title) title in timeline markers.

* STEPS TO REPRODUCE
1. Start timeline
2. setTimeout(function() { console.timeStamp("Message"); })
3. Hover Timeline Marker
  => should see "Message" somewhere.

[Joseph Pecoraro]

Created attachment 264342 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 264343 [details]
[IMAGE] console.timeStamp("Thrusters Engaged")

[Timothy Hatcher]

Comment on attachment 264342 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=264342&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:321
> +                markerElement.title = WebInspector.UIString("%s â %s").format(marker.details, Number.secondsToString(marker.time));

These should likely use the \u encoded form, so the diff tool does not show a bogus char.

[Joseph Pecoraro]

Comment on attachment 264342 [details]
[PATCH] Proposed Fix

Kk. Using emdash here since it is a separator. Updating other inline dashes in localized strings to be \u#### as well.

[Joseph Pecoraro]

Created attachment 264358 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 264358 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264358

Committed r191764: <http://trac.webkit.org/changeset/191764>