Bug 150687 – cdjs-tests.yaml/main.js.ftl fails due to FTL ArithSub code for supporting UntypedUse operands

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

For example, see https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/422.

This issue does not always reproduces.  But on the machines where they do reproduce, it reproduces consistently.

Will disable the feature temporarily until I figure out what the issue is.

[Mark Lam]

This issue is strictly in the FTL and 64-bit only.  There were some 32-bit JSC bots that appeared to be failing due to this.  That was due to a configuration bug on those bots where they were accidentally building 64-bit instead of 32-bit.  That issue has been fixed in http://trac.webkit.org/changeset/191747.

[Mark Lam]

Created attachment 264336 [details]
patch to disable the feature.

[WebKit Commit Bot]

Comment on attachment 264336 [details]
patch to disable the feature.

Rejecting attachment 264336 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 264336, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/354537

[Mark Lam]

Created attachment 264338 [details]
Fixed ChangeLog comment.

[WebKit Commit Bot]

Comment on attachment 264338 [details]
Fixed ChangeLog comment.

Clearing flags on attachment: 264338

Committed r191753: <http://trac.webkit.org/changeset/191753>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Filip Pizlo]

Disabling this optimization by checking the result type is super unusual and likely very fragile.  Can you please use the use kinds instead?