Bug 150686 - Fix Mac CMake build
Summary: Fix Mac CMake build
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Depends on:
Reported: 2015-10-29 12:46 PDT by Alex Christensen
Modified: 2015-10-29 17:42 PDT (History)
3 users (show)

See Also:

Patch (18.99 KB, patch)
2015-10-29 12:47 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (18.85 KB, patch)
2015-10-29 12:57 PDT, Alex Christensen
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-10-29 12:46:37 PDT
Fix Mac CMake build
Comment 1 Alex Christensen 2015-10-29 12:47:30 PDT
Created attachment 264334 [details]
Comment 2 Filip Pizlo 2015-10-29 12:49:07 PDT
Comment on attachment 264334 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=264334&action=review

> Source/JavaScriptCore/b3/B3Common.cpp:43
>      return FTL::verboseCompilationEnabled() || FTL::shouldDumpDisassembly() || shouldDumpIRAtEachPhase();
> +#else
> +    return false;
> +#endif

Why this?  Is there ever a case where B3_JIT is enabled when the FTL_JIT isn't?

If there is such a case, we should prevent B3_JIT from being enabled.
Comment 3 WebKit Commit Bot 2015-10-29 12:49:19 PDT
Attachment 264334 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 20 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2015-10-29 12:57:39 PDT
Created attachment 264335 [details]
Comment 5 Alex Christensen 2015-10-29 13:02:30 PDT
Comment 6 Csaba Osztrogonác 2015-10-29 16:55:16 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/191749

It broke the EFL build, please fix it.
Comment 7 Alex Christensen 2015-10-29 17:42:32 PDT
r191767 should fix EFL.