RESOLVED FIXED 150680
Remove a never used SPI delegate method 
https://bugs.webkit.org/show_bug.cgi?id=150680
Summary Remove a never used SPI delegate method
Anders Carlsson
Reported 2015-10-29 10:57:11 PDT
Remove a never used SPI delegate method
Attachments
Patch (4.65 KB, patch)
2015-10-29 10:59 PDT, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-10-29 10:59:20 PDT
Created attachment 264324 [details] Patch
Beth Dakin
Comment 2 2015-10-29 11:11:31 PDT
Comment on attachment 264324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92 > void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu) Why did you leave an empty stub of this function?
Anders Carlsson
Comment 3 2015-10-29 11:31:34 PDT
Comment on attachment 264324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review >> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92 >> void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu) > > Why did you leave an empty stub of this function? Because it's a client member function and we must have an implementation of it.
Anders Carlsson
Comment 4 2015-10-29 11:31:36 PDT
Committed r191739: <http://trac.webkit.org/changeset/191739>
Note You need to log in before you can comment on or make changes to this bug.