Bug 150680 - Remove a never used SPI delegate method
Summary: Remove a never used SPI delegate method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-29 10:57 PDT by Anders Carlsson
Modified: 2015-10-29 11:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.65 KB, patch)
2015-10-29 10:59 PDT, Anders Carlsson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-10-29 10:57:11 PDT 
Remove a never used SPI delegate method
Comment 1 Anders Carlsson 2015-10-29 10:59:20 PDT 
Created attachment 264324 [details]
Patch
Comment 2 Beth Dakin 2015-10-29 11:11:31 PDT 
Comment on attachment 264324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92
>  void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu)

Why did you leave an empty stub of this function?
Comment 3 Anders Carlsson 2015-10-29 11:31:34 PDT 
Comment on attachment 264324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review

>> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92
>>  void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu)
> 
> Why did you leave an empty stub of this function?

Because it's a client member function and we must have an implementation of it.
Comment 4 Anders Carlsson 2015-10-29 11:31:36 PDT 
Committed r191739: <http://trac.webkit.org/changeset/191739>