Bug 150673 - Modern IDB: deleteObjectStore support
Summary: Modern IDB: deleteObjectStore support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 150719
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2015-10-29 09:22 PDT by Brady Eidson
Modified: 2015-11-02 09:43 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (70.24 KB, patch)
2015-10-29 13:53 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-10-29 09:22:16 PDT 
Modern IDB: deleteObjectStore support
Comment 1 Brady Eidson 2015-10-29 13:53:32 PDT 
Created attachment 264341 [details]
Patch v1
Comment 2 Alex Christensen 2015-10-29 14:35:51 PDT 
Comment on attachment 264341 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=264341&action=review

> Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp:456
> +    auto objectStore = m_referencedObjectStores.take(objectStoreName);
> +    if (objectStore)

Declaration could be inside if

> Source/WebCore/Modules/indexeddb/server/MemoryBackingStoreTransaction.cpp:88
> +    auto addResult = m_deletedObjectStores.add(objectStore->info().name(), nullptr);

ASSERT(objectStore)

> Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp:262
> +

space
Comment 3 Brady Eidson 2015-10-29 15:11:38 PDT 
https://trac.webkit.org/changeset/191758