Bug 150644 - [Content Filtering] Crash when allowing a 0-byte resource to load
Summary: [Content Filtering] Crash when allowing a 0-byte resource to load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-28 16:46 PDT by Andy Estes
Modified: 2015-10-28 17:02 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.75 KB, patch)
2015-10-28 16:50 PDT, Andy Estes
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-10-28 16:46:58 PDT
[Content Filtering] Crash when allowing a 0-byte resource to load
Comment 1 Andy Estes 2015-10-28 16:47:53 PDT
rdar://problem/23288538
Comment 2 Andy Estes 2015-10-28 16:50:54 PDT
Created attachment 264267 [details]
Patch
Comment 3 Darin Adler 2015-10-28 16:56:41 PDT
Comment on attachment 264267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264267&action=review

> Source/WebCore/loader/ContentFilter.cpp:262
> +    if (const SharedBuffer* resourceBuffer = resource.resourceBuffer())

Iā€™d use auto* here instead of const SharedBuffer*.
Comment 4 Andy Estes 2015-10-28 17:02:20 PDT
Committed r191706: <http://trac.webkit.org/changeset/191706>