Bug 150633 - Web Inspector: Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent)
Summary: Web Inspector: Timeline recording start button missing when WEB_REPLAY disabl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-28 12:52 PDT by Joseph Pecoraro
Modified: 2015-10-28 13:42 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.74 KB, patch)
2015-10-28 12:54 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-28 12:52:40 PDT 
* SUMMARY
Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent).

No replay agent was causing us to do:

    element.classList.toggle("foo", undefined)

Which seems turns the class on.

Correct this code to ensure we pass `false`.
Comment 1 Radar WebKit Bug Importer 2015-10-28 12:53:02 PDT 
<rdar://problem/23301173>
Comment 2 Joseph Pecoraro 2015-10-28 12:54:57 PDT 
Created attachment 264234 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2015-10-28 12:55:56 PDT 
Comment on attachment 264234 [details]
[PATCH] Proposed Fix

Makes me wonder if we should audit all our classList.toggle calls.
Comment 4 WebKit Commit Bot 2015-10-28 13:42:44 PDT 
Comment on attachment 264234 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264234

Committed r191689: <http://trac.webkit.org/changeset/191689>
Comment 5 WebKit Commit Bot 2015-10-28 13:42:48 PDT 
All reviewed patches have been landed.  Closing bug.