Bug 150630 - Web Inspector: Rendering Frames pie chart does not update during initial selection of a timeline range
Summary: Web Inspector: Rendering Frames pie chart does not update during initial sele...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-10-28 10:55 PDT by BJ Burg
Modified: 2015-10-28 14:56 PDT (History)
8 users (show)

See Also:


Attachments
[Patch] Proposed Fix (2.82 KB, patch)
2015-10-28 13:34 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-10-28 10:55:58 PDT
Steps to reproduce:

 * Get some content in the timeline
 * Switch to rendering frames view
 * Mousedown in the ruler and drag left or right

Expected:

 * pie chart should live-update as I drag the selection

Actual:

 * pie chart doesn't update until selection is committed (i.e., mouseup)


Notes:

It would seem that we don't create an actual selection until the range is committed, so none of the UI knows to update. In the UI, there is no difference between a real and provisional selection.

Since all of the UI live-updates when panning an already created selection, I don't think this will cause a meaningful perf regression, except in one case. Selecting a range when a busy ScriptTimelineView will be choppy until we fix other filtering/render performance problems.
Comment 1 Radar WebKit Bug Importer 2015-10-28 10:56:41 PDT
<rdar://problem/23298552>
Comment 2 Matt Baker 2015-10-28 13:34:00 PDT
Created attachment 264239 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2015-10-28 13:35:57 PDT
The ruler suppresses changed events while adjusting a newly created selection (one that was created by clicking and dragging outside the existing selection). This effected not just the pie chart, but the updating of the data grid and filtered frame bar styles applied to frames outside the current selection.

This change also causes the other timelines to update their content views when creating a new selection in the manner described.
Comment 4 Geoffrey Garen 2015-10-28 14:09:01 PDT
Comment on attachment 264239 [details]
[Patch] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2015-10-28 14:56:21 PDT
Comment on attachment 264239 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 264239

Committed r191696: <http://trac.webkit.org/changeset/191696>
Comment 6 WebKit Commit Bot 2015-10-28 14:56:25 PDT
All reviewed patches have been landed.  Closing bug.