Bug 150630 – Web Inspector: Rendering Frames pie chart does not update during initial selection of a timeline range

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Steps to reproduce:

 * Get some content in the timeline
 * Switch to rendering frames view
 * Mousedown in the ruler and drag left or right

Expected:

 * pie chart should live-update as I drag the selection

Actual:

 * pie chart doesn't update until selection is committed (i.e., mouseup)


Notes:

It would seem that we don't create an actual selection until the range is committed, so none of the UI knows to update. In the UI, there is no difference between a real and provisional selection.

Since all of the UI live-updates when panning an already created selection, I don't think this will cause a meaningful perf regression, except in one case. Selecting a range when a busy ScriptTimelineView will be choppy until we fix other filtering/render performance problems.

[Radar WebKit Bug Importer]

<rdar://problem/23298552>

[Matt Baker]

Created attachment 264239 [details]
[Patch] Proposed Fix

[Matt Baker]

The ruler suppresses changed events while adjusting a newly created selection (one that was created by clicking and dragging outside the existing selection). This effected not just the pie chart, but the updating of the data grid and filtered frame bar styles applied to frames outside the current selection.

This change also causes the other timelines to update their content views when creating a new selection in the manner described.

[Geoffrey Garen]

Comment on attachment 264239 [details]
[Patch] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 264239 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 264239

Committed r191696: <http://trac.webkit.org/changeset/191696>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.