Bug 150618 - [SOUP] Cannot build the network process in glibc-based BSD systems
Summary: [SOUP] Cannot build the network process in glibc-based BSD systems
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: All Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-28 01:11 PDT by Alberto Garcia
Modified: 2015-10-28 01:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (947 bytes, patch)
2015-10-28 01:12 PDT, Alberto Garcia
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2015-10-28 01:11:12 PDT
r184567 added support for st_birthtime in BSD systems.

However this field is specific to the BSD libc, and therefore is not present on BSD systems that use the glibc, such as Debian GNU/kFreeBSD.

Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp: In function 'WebKit::NetworkCache::FileTimes WebKit::NetworkCache::fileTimes(const WTF::String&)':
Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:101:62: error: 'struct stat' has no member named 'st_birthtime'
     return { std::chrono::system_clock::from_time_t(fileInfo.st_birthtime), std::chrono::system_clock::from_time_t(fileInfo.st_mtime) };
                                                              ^
Comment 1 Alberto Garcia 2015-10-28 01:12:55 PDT
Created attachment 264200 [details]
Patch
Comment 2 Alberto Garcia 2015-10-28 01:42:38 PDT
Committed r191662: <http://trac.webkit.org/changeset/191662>