Bug 150605 - Web Inspector: Remove unused / duplicated XHR timeline instrumentation
Summary: Web Inspector: Remove unused / duplicated XHR timeline instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-10-27 14:37 PDT by Joseph Pecoraro
Modified: 2015-10-27 15:08 PDT (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (20.17 KB, patch)
2015-10-27 14:40 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-10-27 14:37:19 PDT 
* SUMMARY
Remove unused / duplicated XHR timeline instrumentation.

There are two Timeline Events for XHRs (XHRReadyStateChange and XHRLoad) that are themselves unused.

These Timeline Events are only ever created if there are Event Listeners, and always contain an "EventDispatch" record followed by "FunctionCall" meaning that the XHR records and their associated data is never actually used by the frontend.

If we do something for XHRs, we should use a newer type of timeline data construction.
Comment 1 Joseph Pecoraro 2015-10-27 14:40:00 PDT 
Created attachment 264160 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-10-27 15:08:50 PDT 
Comment on attachment 264160 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 264160

Committed r191643: <http://trac.webkit.org/changeset/191643>
Comment 3 WebKit Commit Bot 2015-10-27 15:08:54 PDT 
All reviewed patches have been landed.  Closing bug.