Bug 150603 - Web Inspector: [GTK] Adopt currentColor for mask SVG images
Summary: Web Inspector: [GTK] Adopt currentColor for mask SVG images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: DoNotImportToRadar
Depends on: 150602
Blocks:
  Show dependency tree / graph
 
Reported: 2015-10-27 14:00 PDT by Timothy Hatcher
Modified: 2017-05-18 01:05 PDT (History)
8 users (show)

See Also:

Attachments
Patch (117.37 KB, patch)
2017-05-18 00:04 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
screenshot of before and after this fix (77.48 KB, image/png)
2017-05-18 00:19 PDT, Fujii Hironori 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-10-27 14:00:19 PDT 
I did this for Mac, but it was more difficult for the GTK images. Instead of using the implicit black for fill and stroke, you need to specify "currentColor". This will let the Inspector style the glyphs, specifically the navigation bar items that show up as blue when on/selected.
Comment 1 Andres Gomez Garcia 2015-11-18 07:51:17 PST 
Taking ...
Comment 2 Fujii Hironori 2017-05-18 00:04:21 PDT 
Created attachment 310491 [details]
Patch
Comment 3 Fujii Hironori 2017-05-18 00:19:26 PDT 
Created attachment 310492 [details]
screenshot of before and after this fix
Comment 4 WebKit Commit Bot 2017-05-18 01:05:07 PDT 
Comment on attachment 310491 [details]
Patch

Clearing flags on attachment: 310491

Committed r217039: <http://trac.webkit.org/changeset/217039>
Comment 5 WebKit Commit Bot 2017-05-18 01:05:08 PDT 
All reviewed patches have been landed.  Closing bug.