Bug 150586 - Add the support for Symbol attributes on IDL
Summary: Add the support for Symbol attributes on IDL
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Depends on:
Blocks: 150225
  Show dependency treegraph
Reported: 2015-10-26 19:16 PDT by Ryosuke Niwa
Modified: 2015-10-31 09:36 PDT (History)
4 users (show)

See Also:

Patch (10.78 KB, patch)
2015-10-31 06:49 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-10-26 19:16:16 PDT
We need a mechanism to define a symbol attribute in IDL.
Element.attributeChanged needs to be a symbol to support custom elements.
Comment 1 Yusuke Suzuki 2015-10-26 19:52:14 PDT
My plan is,

1. introducing Symbol type into IDL CodeGenerator
2. implement attributeChanged as static attribute returning Symbol
Comment 2 Yusuke Suzuki 2015-10-31 06:49:55 PDT
Created attachment 264475 [details]
Comment 3 Ryosuke Niwa 2015-10-31 06:51:26 PDT
Comment on attachment 264475 [details]

Comment 4 WebKit Commit Bot 2015-10-31 08:37:54 PDT
Comment on attachment 264475 [details]

Clearing flags on attachment: 264475

Committed r191841: <http://trac.webkit.org/changeset/191841>
Comment 5 WebKit Commit Bot 2015-10-31 08:37:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Yusuke Suzuki 2015-10-31 09:36:16 PDT
The tests failed, but it seems that this change is not relate to that.
I guess the failures are caused due to Daylight Saving Time.