http/tests/contentextensions/async-xhr-onerror.html is flaky on mac-wk2 <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions%2Fasync-xhr-onerror.html> --- /Volumes/Data/slave/mavericks-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/async-xhr-onerror-expected.txt +++ /Volumes/Data/slave/mavericks-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/async-xhr-onerror-actual.txt @@ -5,6 +5,7 @@ Asynchronous onreadystatechange status: 0, readyState:1, responseText: Finished runTest. Waiting for callbacks Asynchronous onreadystatechange status: 0, readyState:4, responseText: +timeout - this should not be called. onerror was called. Asynchronous onreadystatechange status: 0, readyState:4, responseText: onerror was called.
Marked as flaky in <https://trac.webkit.org/r192059>
Created attachment 264954 [details] Patch
This should be landed along with marking the test as not flaky any more.
Comment on attachment 264954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264954&action=review > Source/WebCore/xml/XMLHttpRequest.cpp:786 > + if (m_timeoutTimer.isActive()) > + m_timeoutTimer.stop(); Why do we need the "!isActive" check here? Calling stop should be harmless if the timer is not active.
(In reply to comment #4) > Comment on attachment 264954 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264954&action=review > > > Source/WebCore/xml/XMLHttpRequest.cpp:786 > > + if (m_timeoutTimer.isActive()) > > + m_timeoutTimer.stop(); > > Why do we need the "!isActive" check here? Calling stop should be harmless > if the timer is not active. It was done elsewhere in this file. I'll remove it elsewhere.
Created attachment 265081 [details] Patch
Comment on attachment 265081 [details] Patch Clearing flags on attachment: 265081 Committed r192175: <http://trac.webkit.org/changeset/192175>
All reviewed patches have been landed. Closing bug.