Bug 150576 - Make IDBKeyData from a struct to a class
Summary: Make IDBKeyData from a struct to a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-26 15:15 PDT by Brady Eidson
Modified: 2015-10-26 22:23 PDT (History)
6 users (show)

See Also:

Attachments
patch v1 (29.45 KB, patch)
2015-10-26 15:17 PDT, Brady Eidson 		beidson: review-
Details | Formatted Diff | Diff
Patch v2 - Including all the changes this time (33.73 KB, patch)
2015-10-26 15:49 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v3 (33.68 KB, patch)
2015-10-26 15:53 PDT, Brady Eidson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (702.49 KB, application/zip)
2015-10-26 16:14 PDT, Build Bot 		no flags Details
Patch v4 (33.70 KB, patch)
2015-10-26 16:20 PDT, Brady Eidson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (745.86 KB, application/zip)
2015-10-26 16:40 PDT, Build Bot 		no flags Details
Patch v5 - Piece of cake (33.76 KB, patch)
2015-10-26 16:47 PDT, Brady Eidson 		achristensen: review+
beidson: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (1.05 MB, application/zip)
2015-10-26 17:40 PDT, Build Bot 		no flags Details
Patch v6 - for landing, after fixing boneheaded mistake (33.77 KB, patch)
2015-10-26 20:25 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2015-10-26 15:15:48 PDT 
Make IDBKeyData from a struct to a class.
Comment 1 Brady Eidson 2015-10-26 15:17:18 PDT 
Created attachment 264081 [details]
patch v1
Comment 2 Brady Eidson 2015-10-26 15:49:16 PDT 
Created attachment 264085 [details]
Patch v2 - Including all the changes this time
Comment 3 Brady Eidson 2015-10-26 15:53:35 PDT 
Created attachment 264087 [details]
Patch v3
Comment 4 Build Bot 2015-10-26 16:14:28 PDT 
Comment on attachment 264087 [details]
Patch v3

Attachment 264087 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/341625

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2015-10-26 16:14:31 PDT 
Created attachment 264090 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Brady Eidson 2015-10-26 16:20:12 PDT 
Created attachment 264092 [details]
Patch v4
Comment 7 Build Bot 2015-10-26 16:40:05 PDT 
Comment on attachment 264092 [details]
Patch v4

Attachment 264092 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/341709

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2015-10-26 16:40:07 PDT 
Created attachment 264094 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 Brady Eidson 2015-10-26 16:47:03 PDT 
Created attachment 264095 [details]
Patch v5 - Piece of cake
Comment 10 Build Bot 2015-10-26 17:40:39 PDT 
Comment on attachment 264095 [details]
Patch v5 - Piece of cake

Attachment 264095 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/341885

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2015-10-26 17:40:41 PDT 
Created attachment 264107 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 12 Brady Eidson 2015-10-26 20:25:44 PDT 
Created attachment 264116 [details]
Patch v6 - for landing, after fixing boneheaded mistake
Comment 13 WebKit Commit Bot 2015-10-26 22:23:42 PDT 
Comment on attachment 264116 [details]
Patch v6 - for landing, after fixing boneheaded mistake

Clearing flags on attachment: 264116

Committed r191620: <http://trac.webkit.org/changeset/191620>
Comment 14 WebKit Commit Bot 2015-10-26 22:23:47 PDT 
All reviewed patches have been landed.  Closing bug.