Bug 150565 - id of iframe incorrectly sets window name
Summary: id of iframe incorrectly sets window name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://www.whatwg.org/specs/web-apps/...
Keywords: BlinkMergeCandidate, WebExposed
Depends on: 150861
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-26 10:47 PDT by Chris Dumez
Modified: 2015-11-03 15:40 PST (History)
7 users (show)

See Also:


Attachments
Patch (120.28 KB, patch)
2015-10-26 15:00 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-mavericks (775.36 KB, application/zip)
2015-10-26 15:38 PDT, Build Bot
no flags Details
Patch (128.70 KB, patch)
2015-10-26 15:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2015-10-26 10:47:03 PDT
As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, WebKit is using the iframe's id as window name if the name is unset.

Test case:
http://jsfiddle.net/xf5H7/9/

Firefox, IE and Chrome behave according to the specification.

Blink commit:
https://src.chromium.org/viewvc/blink?revision=169803&view=revision
Comment 1 Chris Dumez 2015-10-26 15:00:23 PDT
Created attachment 264079 [details]
Patch
Comment 2 Build Bot 2015-10-26 15:38:48 PDT
Comment on attachment 264079 [details]
Patch

Attachment 264079 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/341461

New failing tests:
fast/frames/sandboxed-iframe-plugins.html
http/tests/loading/redirect-methods.html
http/tests/navigation/forward-and-cancel.html
plugins/get-url-with-iframe-target.html
webarchive/archive-empty-frame-source.html
http/tests/security/cross-frame-access-protocol.html
http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html
http/tests/security/cross-frame-access-protocol-explicit-domain.html
Comment 3 Build Bot 2015-10-26 15:38:52 PDT
Created attachment 264082 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Chris Dumez 2015-10-26 15:51:33 PDT
Created attachment 264086 [details]
Patch
Comment 5 WebKit Commit Bot 2015-10-27 21:40:52 PDT
Comment on attachment 264086 [details]
Patch

Clearing flags on attachment: 264086

Committed r191652: <http://trac.webkit.org/changeset/191652>
Comment 6 WebKit Commit Bot 2015-10-27 21:40:58 PDT
All reviewed patches have been landed.  Closing bug.